Microoptimizations on DateTimeParser - #2990
Open
Henr1k80 wants to merge 9 commits into
Open
Conversation
…fferent than 24, minute & seconds are less likely to be 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have reduced the size of the
DateTimeParserstructthat is being copied when callingCreateDateTimeThe reduced size of the JIT assembly can be seen here
(Remove
: byteon theenum& changebyte/ushortfields toint)Works for both Framework and .NET 8
Optimized the time verification, hour is very likely to be different than 24, minute & seconds are less likely to be 0, so we can exit earlier out of the checks.
Reusing the
start + 1calculation inParse2Digitsaves one line of JIT assembly 😅Optimized some benchmarks so they mainly test (de)serialization & added one for deserialization of dates.
Fixed some unit tests for da-DK culture.
Gitignore Rider files.
DateTimeParser haven't changed in 9 years, so these changes can be backported to the many versions used